Problem with dependency injection (File::load and Drupal::service)

In order to make a managed_file field permanent I did this in my module configuration form:

<?php  namespace Drupalmy_moduleForm;  use DrupalCoreFormConfigFormBase; use DrupalCoreFormFormStateInterface;  /**  * Class MymoduleSettings.  */ class MymoduleSettings extends ConfigFormBase {    /**    * {@inheritdoc}    */   public function getFormId() {     return 'my_module_settings';   }    /**    * {@inheritdoc}    */   public function buildForm(array $form, FormStateInterface $form_state) {     $config                    = $this->config('my_module.settings');     $form['my_module_title'] = [       '#type'          => 'textfield',       '#title'         => $this->t('Title'),       '#description'   => $this->t("Enter the title"),       '#maxlength'     => 64,       '#size'          => 64,       '#required'      => TRUE,       '#default_value' => $config->get('my_module_title'),     ];     $form['mymodule_icon']   = [       '#type'              => 'managed_file',       '#title'             => $this->t('Icon'),       '#description'       => $this->t("Upload the image file for the icon"),       '#upload_location'   => 'public://',       '#upload_validators' => [         'file_validate_extensions' => ['gif png jpg jpeg'],       ],       '#default_value'     => $config->get('my_module_icon'),     ];     return parent::buildForm($form, $form_state);   }    /**    * {@inheritdoc}    */   public function submitForm(array &$form, FormStateInterface $form_state) {     parent::submitForm($form, $form_state);      $this->config('my_module.settings')       ->set('my_module_title', $form_state->getValue('my_module_title'))       ->set('my_module_icon', $form_state->getValue('my_module_icon'))       ->save();      // First we just grab the file ID for the icon we uploaded, if any.     $icon_field = $form_state->getValue('my_module_icon');     $file_id    = empty($icon_field) ? FALSE : reset($icon_field);      if (!empty($file_id)) {       // Make this a permanent file so that cron doesn't delete it later.       $file         = File::load($file_id);       $file->status = FILE_STATUS_PERMANENT;       $file->save();       $file_usage = Drupal::service('file.usage');       $file_usage->add($file, 'my_module', 'file', $file_id);     }   }    /**    * {@inheritdoc}    */   protected function getEditableConfigNames() {     return [       'my_module.settings',     ];   }  } 

but I’m getting warning to use dependency injection principle in this case:

File::load calls should be avoided in classes, use dependency injection instead 

and

Drupal calls should be avoided in classes, use dependency injection instead 

I looked through Dependency Injection for a Form but still not sure that I really get it.

Can someone explain me what I need to do in this particular case so I can get a better view on this issue and figure it out?

This article was republished from its original source.
Call Us: 1(800)730-2416

Pixeldust is a 20-year-old web development agency specializing in Drupal and WordPress and working with clients all over the country. With our best in class capabilities, we work with small businesses and fortune 500 companies alike. Give us a call at 1(800)730-2416 and let’s talk about your project.

FREE Drupal SEO Audit

Test your site below to see which issues need to be fixed. We will fix them and optimize your Drupal site 100% for Google and Bing. (Allow 30-60 seconds to gather data.)

Powered by

Problem with dependency injection (File::load and Drupal::service)

On-Site Drupal SEO Master Setup

We make sure your site is 100% optimized (and stays that way) for the best SEO results.

With Pixeldust On-site (or On-page) SEO we make changes to your site’s structure and performance to make it easier for search engines to see and understand your site’s content. Search engines use algorithms to rank sites by degrees of relevance. Our on-site optimization ensures your site is configured to provide information in a way that meets Google and Bing standards for optimal indexing.

This service includes:

  • Pathauto install and configuration for SEO-friendly URLs.
  • Meta Tags install and configuration with dynamic tokens for meta titles and descriptions for all content types.
  • Install and fix all issues on the SEO checklist module.
  • Install and configure XML sitemap module and submit sitemaps.
  • Install and configure Google Analytics Module.
  • Install and configure Yoast.
  • Install and configure the Advanced Aggregation module to improve performance by minifying and merging CSS and JS.
  • Install and configure Schema.org Metatag.
  • Configure robots.txt.
  • Google Search Console setup snd configuration.
  • Find & Fix H1 tags.
  • Find and fix duplicate/missing meta descriptions.
  • Find and fix duplicate title tags.
  • Improve title, meta tags, and site descriptions.
  • Optimize images for better search engine optimization. Automate where possible.
  • Find and fix the missing alt and title tag for all images. Automate where possible.
  • The project takes 1 week to complete.