Multiple unnecessary joins when creating an andConditionGroup()

I have a large array of names and surnames, I need to know which of these differ from the current ones in the database.

For example:

    $largeList = largeList();
    $storage = $this->entityTypeManager->getStorage("mi_entity");
    $query = $storage->getQuery();

    foreach ($largeList as $item) {
      $andGroup = $query->andConditionGroup();
      $andGroup
        ->condition('name', $item->getName(), "<>")
        ->condition('surname', $item->getSurname(), "<>");
      $query->condition($andGroup);
    }

    $ids = $query->execute();

The idea is to compare on the first and last names, for example the part of the sql condition should look something similar to this:

SELECT
   "base_table"."id" AS "id",
   "base_table"."id" AS "base_table_id" 
FROM
   "entity_table" "base_table" 
   INNER JOIN
      "entity_table" "entity_table" 
      ON "entity_table"."id" = "base_table"."id"
WHERE
 (("entity_table"."name" NOT LIKE 'NAME 1' ESCAPE '\') and ("entity_table"."surname" NOT LIKE 'LAST NAME 1' ESCAPE '\')) AND 
 (("entity_table"."name" NOT LIKE 'NAME 2' ESCAPE '\') and ("entity_table"."surname" NOT LIKE 'LAST NAME 2' ESCAPE '\')) AND ......

However, the code above as an example, generates an additional join for each item in the array like this:

SELECT
   "base_table"."id" AS "id",
   "base_table"."id" AS "base_table_id" 
FROM
   "entity_table" "base_table" 
   INNER JOIN
      "entity_table" "entity_table" 
      ON "entity_table"."id" = "base_table"."id" 
   INNER JOIN
      "entity_table" "entity_table_2" 
      ON "entity_table_2"."id" = "base_table"."id" 
   INNER JOIN
      "entity_table" "entity_table_3" 
      ON "entity_table_3"."id" = "base_table"."id" 
   INNER JOIN
      "entity_table" "entity_table_4" 
      ON "entity_table_4"."id" = "base_table"."id" 

      WHERE
   (("entity_table"."name" NOT LIKE 'NAME 1' ESCAPE '\') and ("entity_table"."surname" NOT LIKE 'LAST NAME 1' ESCAPE '\')) AND 
   (("entity_table_2"."name" NOT LIKE 'NAME 2' ESCAPE '\') and ("entity_table_2"."surname" NOT LIKE 'LAST NAME 2' ESCAPE '\')) AND 
   (("entity_table_3"."name" NOT LIKE 'NAME 3' ESCAPE '\') and ("entity_table_3"."surname" NOT LIKE 'LAST NAME 3' ESCAPE '\')) AND 
   (("entity_table_4"."name" NOT LIKE 'NAME 4' ESCAPE '\') and ("entity_table_4"."surname" NOT LIKE 'LAST NAME 4' ESCAPE '\'))

In this excerpt from the query, I only show 4 conditions that generate 4 joins, but if I have 500, it generates 500 joins.
What would be the correct way to write the condition to avoid these unnecessary joins ?

This article was republished from its original source.
Call Us: 1(800)730-2416

Pixeldust is a 20-year-old web development agency specializing in Drupal and WordPress and working with clients all over the country. With our best in class capabilities, we work with small businesses and fortune 500 companies alike. Give us a call at 1(800)730-2416 and let’s talk about your project.

FREE Drupal SEO Audit

Test your site below to see which issues need to be fixed. We will fix them and optimize your Drupal site 100% for Google and Bing. (Allow 30-60 seconds to gather data.)

Powered by

Multiple unnecessary joins when creating an andConditionGroup()

On-Site Drupal SEO Master Setup

We make sure your site is 100% optimized (and stays that way) for the best SEO results.

With Pixeldust On-site (or On-page) SEO we make changes to your site’s structure and performance to make it easier for search engines to see and understand your site’s content. Search engines use algorithms to rank sites by degrees of relevance. Our on-site optimization ensures your site is configured to provide information in a way that meets Google and Bing standards for optimal indexing.

This service includes:

  • Pathauto install and configuration for SEO-friendly URLs.
  • Meta Tags install and configuration with dynamic tokens for meta titles and descriptions for all content types.
  • Install and fix all issues on the SEO checklist module.
  • Install and configure XML sitemap module and submit sitemaps.
  • Install and configure Google Analytics Module.
  • Install and configure Yoast.
  • Install and configure the Advanced Aggregation module to improve performance by minifying and merging CSS and JS.
  • Install and configure Schema.org Metatag.
  • Configure robots.txt.
  • Google Search Console setup snd configuration.
  • Find & Fix H1 tags.
  • Find and fix duplicate/missing meta descriptions.
  • Find and fix duplicate title tags.
  • Improve title, meta tags, and site descriptions.
  • Optimize images for better search engine optimization. Automate where possible.
  • Find and fix the missing alt and title tag for all images. Automate where possible.
  • The project takes 1 week to complete.